1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug#46018 group_concat(distinct ...) uses max_heap_table_size for memory allocations

Browse Source 
Use min(max_heap_table_size, tmp_table_size) instead

per-file comments:
  sql/item_sum.cc
Bug#46018      group_concat(distinct ...) uses max_heap_table_size for memory allocations
    Item_sum_**::setup fixed, so they use ram_limitation() for Unique-s they embed

  sql/item_sum.h
Bug#46018      group_concat(distinct ...) uses max_heap_table_size for memory allocations
   Item_sum::ram_limitation() declared
This commit is contained in:
Alexey Botchkov 2009-10-01 16:33:30 +05:00
parent 289f4a4083
commit cd994f0ee4
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sql/item_sum.cc
View File

@ -28,6 +28,17 @@
#include "mysql_priv.h" #include "mysql_priv.h"
#include "sql_select.h" #include "sql_select.h"
/**
Calculate the affordable RAM limit for structures like TREE or Unique
used in Item_sum_*
*/
ulonglong Item_sum::ram_limitation(THD *thd)
{
return min(thd->variables.tmp_table_size,
thd->variables.max_heap_table_size);
}
/** /**
Prepare an aggregate function item for checking context conditions. Prepare an aggregate function item for checking context conditions.
@ -1045,7 +1056,7 @@ bool Item_sum_distinct::setup(THD *thd)
are converted to binary representation as well. are converted to binary representation as well.
*/ */
tree= new Unique(simple_raw_key_cmp, &tree_key_length, tree_key_length, tree= new Unique(simple_raw_key_cmp, &tree_key_length, tree_key_length,
thd->variables.max_heap_table_size); ram_limitation(thd));
is_evaluated= FALSE; is_evaluated= FALSE;
DBUG_RETURN(tree == 0); DBUG_RETURN(tree == 0);
@ -2683,8 +2694,7 @@ bool Item_sum_count_distinct::setup(THD *thd)
} }
} }
DBUG_ASSERT(tree == 0); DBUG_ASSERT(tree == 0);
tree= new Unique(compare_key, cmp_arg, tree_key_length, tree= new Unique(compare_key,cmp_arg,tree_key_length, ram_limitation(thd));
thd->variables.max_heap_table_size);
/* /*
The only time tree_key_length could be 0 is if someone does The only time tree_key_length could be 0 is if someone does
count(distinct) on a char(0) field - stupid thing to do, count(distinct) on a char(0) field - stupid thing to do,
@ -3529,7 +3539,7 @@ bool Item_func_group_concat::setup(THD *thd)
unique_filter= new Unique(group_concat_key_cmp_with_distinct, unique_filter= new Unique(group_concat_key_cmp_with_distinct,
(void*)this, (void*)this,
tree_key_length, tree_key_length,
thd->variables.max_heap_table_size); ram_limitation(thd));
DBUG_RETURN(FALSE); DBUG_RETURN(FALSE);
} }

1
sql/item_sum.h
View File

@ -256,6 +256,7 @@ protected:
Item **orig_args, *tmp_orig_args[2]; Item **orig_args, *tmp_orig_args[2];
table_map used_tables_cache; table_map used_tables_cache;
bool forced_const; bool forced_const;
static ulonglong ram_limitation(THD *thd);
public: public: