From c7c0959c196958d184bcdeacb7f0e088e1d0d54c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Otto=20Kek=C3=A4l=C3=A4inen?= Date: Wed, 4 Mar 2020 19:23:05 +0200 Subject: [PATCH] Use correct reference in man page links After the '.so' one is supposed to use the directory name, like we have correctly in all old man pages: mysql_client_test_embedded.1:.so man1/mysql_client_test.1 mysql_embedded.1:.so man1/mysql.1 mysqltest_embedded.1:.so man1/mysqltest.1 This change adds the 'man1/' component so the link has the correct format. Actually using man links is a deprecated practice and using symlinks would be better, but that can be fixed in a later commit. From https://www.debian.org/doc/debian-policy/ch-docs.html#manual-pages: > If one man page needs to be accessible via several names it is better > to use a symbolic link than the .so feature Detected via Lintian errors: E: mariadb-server-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-show.1.gz E: mariadb-client-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-binlog.1.gz E: mariadb-client-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-plugin.1.gz Related to MDEV-21769. --- man/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/CMakeLists.txt b/man/CMakeLists.txt index 5f85eb950ab..f083c549901 100644 --- a/man/CMakeLists.txt +++ b/man/CMakeLists.txt @@ -80,7 +80,7 @@ endmacro(MARIADB_SYMLINK_MANPAGE) macro(MARIADB_SYMLINK_MANPAGE_CREATE mysqlname index mannr dir comp) LIST(GET MARIADB_SYMLINK_TOS ${index} _mariadbname) SET(dest "${CMAKE_CURRENT_BINARY_DIR}/${_mariadbname}.${mannr}") - FILE(WRITE ${dest} ".so ${mysqlname}.${mannr}") + FILE(WRITE ${dest} ".so ${dir}/${mysqlname}.${mannr}") INSTALL(FILES ${dest} DESTINATION ${INSTALL_MANDIR}/${dir} COMPONENT ${comp}) endmacro(MARIADB_SYMLINK_MANPAGE_CREATE)