From 31608f67ab310e7c84477a79d5b2f683113365e0 Mon Sep 17 00:00:00 2001
From: unknown <dkatz@damien-katzs-computer.local>
Date: Wed, 13 Jun 2007 16:24:21 -0400
Subject: [PATCH] Bug #28953  	Using events in a replication let the slave
 crash.

Fixed where the slave code would try to update the Lex->sphead which is NULL on an "alter table" commands.


mysql-test/r/rpl_events.result:
  test that "alter event" replicates without crashing the slave
mysql-test/t/rpl_events.test:
  test that "alter event" replicates without crashing the slave
sql/sql_parse.cc:
  Added a check for lex->spd, which isn't set on an "alter event" command
---
 mysql-test/r/rpl_events.result |  6 ++++++
 mysql-test/t/rpl_events.test   | 23 +++++++++++++++++++++++
 sql/sql_parse.cc               |  2 +-
 3 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/mysql-test/r/rpl_events.result b/mysql-test/r/rpl_events.result
index debfcce0072..0d7e7bb28a7 100644
--- a/mysql-test/r/rpl_events.result
+++ b/mysql-test/r/rpl_events.result
@@ -157,3 +157,9 @@ test	slave_terminate	SLAVESIDE_DISABLED	2
 DROP EVENT test.slave_terminate;
 "in the master"
 DROP TABLE t1;
+CREATE EVENT event1 ON SCHEDULE EVERY 1 YEAR
+DO BEGIN
+select * from t1;
+END;|
+ALTER EVENT event1 RENAME TO event2;
+DROP EVENT event2;
diff --git a/mysql-test/t/rpl_events.test b/mysql-test/t/rpl_events.test
index 895e94c438b..62ffead7dcb 100644
--- a/mysql-test/t/rpl_events.test
+++ b/mysql-test/t/rpl_events.test
@@ -22,3 +22,26 @@ set binlog_format=statement;
 # Embedded server doesn't support binlogging
 --source include/rpl_events.inc
 
+#
+# Bug #28953  	Using events in a replication let the slave crash.
+#
+
+connection master;
+
+DELIMITER |;
+CREATE EVENT event1 ON SCHEDULE EVERY 1 YEAR
+DO BEGIN
+	select * from t1;
+END;|
+DELIMITER ;|
+
+ALTER EVENT event1 RENAME TO event2;
+
+sync_slave_with_master;
+
+connection master;
+
+DROP EVENT event2;
+
+sync_slave_with_master;
+
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc
index 31e3196ded1..1b06f5567d8 100644
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -1567,7 +1567,7 @@ bool sp_process_definer(THD *thd)
     if (lex->definer == NULL)
       DBUG_RETURN(TRUE);
 
-    if (thd->slave_thread)
+    if (thd->slave_thread && lex->sphead)
       lex->sphead->m_chistics->suid= SP_IS_NOT_SUID;
   }
   else