From 0c79ae94626406afe29c053c54257356d9beda00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20M=C3=A4kel=C3=A4?= Date: Thu, 16 Feb 2023 10:09:19 +0200 Subject: [PATCH 1/2] Fix clang -Winconsistent-missing-override --- sql/item.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/item.h b/sql/item.h index 38773fd3ba8..79e93fda35f 100644 --- a/sql/item.h +++ b/sql/item.h @@ -3512,7 +3512,7 @@ public: { return Sql_mode_dependency(0, field->value_depends_on_sql_mode()); } - bool hash_not_null(Hasher *hasher) + bool hash_not_null(Hasher *hasher) override { if (field->is_null()) return true; From d3f35aa47bc3ee0c9b2798555f9a79057895809a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20M=C3=A4kel=C3=A4?= Date: Thu, 16 Feb 2023 10:16:38 +0200 Subject: [PATCH 2/2] MDEV-30552 fixup: Fix the test for non-debug --- mysql-test/suite/innodb/r/recovery_memory.result | 2 +- mysql-test/suite/innodb/t/recovery_memory.test | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/mysql-test/suite/innodb/r/recovery_memory.result b/mysql-test/suite/innodb/r/recovery_memory.result index 6faea097616..9aba9bccdb3 100644 --- a/mysql-test/suite/innodb/r/recovery_memory.result +++ b/mysql-test/suite/innodb/r/recovery_memory.result @@ -22,7 +22,7 @@ DROP PROCEDURE dorepeat; SET DEBUG_DBUG="+d,ib_log_checkpoint_avoid_hard"; CREATE TABLE t1(f1 INT NOT NULL)ENGINE=InnoDB; INSERT INTO t1 SELECT * FROM seq_1_to_65536; -# restart: --innodb_buffer_pool_size=5242880 --debug_dbug=+d,ibuf_init_corrupt +# restart: with restart_parameters # restart SHOW CREATE TABLE t1; Table Create Table diff --git a/mysql-test/suite/innodb/t/recovery_memory.test b/mysql-test/suite/innodb/t/recovery_memory.test index e723ba25d36..145b39d56f6 100644 --- a/mysql-test/suite/innodb/t/recovery_memory.test +++ b/mysql-test/suite/innodb/t/recovery_memory.test @@ -1,6 +1,7 @@ --source include/have_innodb.inc --source include/big_test.inc --source include/have_sequence.inc +--source include/maybe_debug.inc call mtr.add_suppression("InnoDB: The change buffer is corrupted"); call mtr.add_suppression("InnoDB: Plugin initialization aborted at srv0start.cc"); call mtr.add_suppression("Plugin 'InnoDB' init function returned error"); @@ -30,12 +31,20 @@ DROP PROCEDURE dorepeat; --echo # MDEV-30552 InnoDB recovery crashes when error --echo # handling scenario --echo # +if ($have_debug) { SET DEBUG_DBUG="+d,ib_log_checkpoint_avoid_hard"; +let $restart_parameters=--innodb_buffer_pool_size=5242880 --debug_dbug="+d,ibuf_init_corrupt"; +} +if (!$have_debug) { +--echo SET DEBUG_DBUG="+d,ib_log_checkpoint_avoid_hard"; +let $restart_parameters=--innodb_buffer_pool_size=5242880; +} CREATE TABLE t1(f1 INT NOT NULL)ENGINE=InnoDB; INSERT INTO t1 SELECT * FROM seq_1_to_65536; +let $restart_noprint=1; let $shutdown_timeout=0; -let $restart_parameters=--innodb_buffer_pool_size=5242880 --debug_dbug="+d,ibuf_init_corrupt"; --source include/restart_mysqld.inc +let $restart_noprint=0; let $restart_parameters=; --source include/restart_mysqld.inc SHOW CREATE TABLE t1;