1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG#29734 - thread_id=0 in binary log which leads to temporary table conflicts

Browse Source 
pseudo_thread_id was reset to zero via mysql_change_user() handling
whereas there is no reason to do that.  Moreover, having two
concurrent threads that change user and create a namesake temp tables
leads to recording the dup pair of queries:

   set @@session.pseudo_thread_id = 0;
   CREATE temporary table `the namesake`;

which will stall the slave as the second instance can not be created.
And that is the bug case.

Fixed by correcting pseudo_thread_id value after mysql_change_user().


sql/sql_class.cc:
  Fixed that pseudo_thread_id was set to 0 after mysql_change_user().
This commit is contained in:
unknown 2007-07-14 17:58:39 +05:00
parent 15a9301a29
commit a9c6a0bbbc
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sql/sql_class.cc
View File

@ -211,7 +211,7 @@ THD::THD()
time_after_lock=(time_t) 0; time_after_lock=(time_t) 0;
current_linfo = 0; current_linfo = 0;
slave_thread = 0; slave_thread = 0;
variables.pseudo_thread_id= 0; thread_id= 0;
one_shot_set= 0; one_shot_set= 0;
file_id = 0; file_id = 0;
query_id= 0; query_id= 0;
@ -328,6 +328,12 @@ void THD::init(void)
variables.date_format); variables.date_format);
variables.datetime_format= date_time_format_copy((THD*) 0, variables.datetime_format= date_time_format_copy((THD*) 0,
variables.datetime_format); variables.datetime_format);
/*
variables= global_system_variables above has reset
variables.pseudo_thread_id to 0. We need to correct it here to
avoid temporary tables replication failure.
*/
variables.pseudo_thread_id= thread_id;
pthread_mutex_unlock(&LOCK_global_system_variables); pthread_mutex_unlock(&LOCK_global_system_variables);
server_status= SERVER_STATUS_AUTOCOMMIT; server_status= SERVER_STATUS_AUTOCOMMIT;
if (variables.sql_mode & MODE_NO_BACKSLASH_ESCAPES) if (variables.sql_mode & MODE_NO_BACKSLASH_ESCAPES)
@ -579,6 +585,9 @@ bool THD::store_globals()
By default 'slave_proxy_id' is 'thread_id'. They may later become different By default 'slave_proxy_id' is 'thread_id'. They may later become different
if this is the slave SQL thread. if this is the slave SQL thread.
*/ */
/** @todo we already do it in init(), see if we still need to do it here.
add DBUG_ASSERT(variables.pseudo_thread_id == thread_id)
*/
variables.pseudo_thread_id= thread_id; variables.pseudo_thread_id= thread_id;
/* /*
We have to call thr_lock_info_init() again here as THD may have been We have to call thr_lock_info_init() again here as THD may have been