1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug #16874 memory leaks in rpl_row_basic_7ndb.test

Browse Source 
- free ndb shares at server shutdown
- free_table_share at free of ndb_share
This commit is contained in:
tomas@poseidon.ndb.mysql.com 2006-03-07 12:19:27 +01:00
parent 1e0289041c
commit a0f82c18ef
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
sql/ha_ndbcluster.cc
View File

@ -5995,6 +5995,22 @@ static int ndbcluster_end(ha_panic_function type)
delete g_ndb_cluster_connection; delete g_ndb_cluster_connection;
g_ndb_cluster_connection= NULL; g_ndb_cluster_connection= NULL;
#ifdef HAVE_NDB_BINLOG
{
pthread_mutex_lock(&ndbcluster_mutex);
for (uint i= 0; i < ndbcluster_open_tables.records; i++)
{
NDB_SHARE *share=
(NDB_SHARE*) hash_element(&ndbcluster_open_tables, i);
#ifndef DBUG_OFF
fprintf(stderr, "NDB: table share %s with use_count %d not freed\n",
share->key, share->use_count);
#endif
real_free_share(&share);
}
pthread_mutex_unlock(&ndbcluster_mutex);
}
#endif
hash_free(&ndbcluster_open_tables); hash_free(&ndbcluster_open_tables);
pthread_mutex_destroy(&ndbcluster_mutex); pthread_mutex_destroy(&ndbcluster_mutex);
pthread_mutex_destroy(&LOCK_ndb_util_thread); pthread_mutex_destroy(&LOCK_ndb_util_thread);
@ -6843,11 +6859,10 @@ void ndbcluster_real_free_share(NDB_SHARE **share)
#ifdef HAVE_NDB_BINLOG #ifdef HAVE_NDB_BINLOG
if ((*share)->table) if ((*share)->table)
{ {
// (*share)->table->mem_root is freed by closefrm
closefrm((*share)->table, 0); closefrm((*share)->table, 0);
#if 0 // todo ? // (*share)->table_share->mem_root is freed by free_table_share
free_root(&(*share)->table->mem_root, MYF(0)); free_table_share((*share)->table_share);
#endif
#ifndef DBUG_OFF #ifndef DBUG_OFF
bzero((gptr)(*share)->table_share, sizeof(*(*share)->table_share)); bzero((gptr)(*share)->table_share, sizeof(*(*share)->table_share));
bzero((gptr)(*share)->table, sizeof(*(*share)->table)); bzero((gptr)(*share)->table, sizeof(*(*share)->table));