1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Automerge.

Browse Source
This commit is contained in:
Ramil Kalimullin 2010-06-24 15:26:14 +04:00
commit a08780df98
3 changed files with 34 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mysql-test/r/func_like.result
View File

@ -169,3 +169,17 @@ select 'andre%' like 'andre
select _cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê'; select _cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê';
_cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê' _cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê'
1 1
End of 4.1 tests
#
# Bug #54575: crash when joining tables with unique set column
#
CREATE TABLE t1(a SET('a') NOT NULL, UNIQUE KEY(a));
CREATE TABLE t2(b INT PRIMARY KEY);
INSERT INTO t1 VALUES ();
Warnings:
Warning 1364 Field 'a' doesn't have a default value
INSERT INTO t2 VALUES (1), (2), (3);
SELECT 1 FROM t2 JOIN t1 ON 1 LIKE a GROUP BY a;
1
DROP TABLE t1, t2;
End of 5.1 tests

18
mysql-test/t/func_like.test
View File

@ -112,5 +112,19 @@ select 'andre%' like 'andre
# #
select _cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê'; select _cp1251'andre%' like convert('andreÊ%' using cp1251) escape 'Ê';
#
# End of 4.1 tests --echo End of 4.1 tests
--echo #
--echo # Bug #54575: crash when joining tables with unique set column
--echo #
CREATE TABLE t1(a SET('a') NOT NULL, UNIQUE KEY(a));
CREATE TABLE t2(b INT PRIMARY KEY);
INSERT INTO t1 VALUES ();
INSERT INTO t2 VALUES (1), (2), (3);
SELECT 1 FROM t2 JOIN t1 ON 1 LIKE a GROUP BY a;
DROP TABLE t1, t2;
--echo End of 5.1 tests

7
sql/item_cmpfunc.cc
View File

@ -4578,13 +4578,14 @@ Item_func::optimize_type Item_func_like::select_optimize() const
if (args[1]->const_item()) if (args[1]->const_item())
{ {
String* res2= args[1]->val_str((String *)&cmp.value2); String* res2= args[1]->val_str((String *)&cmp.value2);
const char *ptr2;
if (!res2) if (!res2 || !(ptr2= res2->ptr()))
return OPTIMIZE_NONE; return OPTIMIZE_NONE;
if (*res2->ptr() != wild_many) if (*ptr2 != wild_many)
{ {
if (args[0]->result_type() != STRING_RESULT || *res2->ptr() != wild_one) if (args[0]->result_type() != STRING_RESULT || *ptr2 != wild_one)
return OPTIMIZE_OP; return OPTIMIZE_OP;
} }
} }