1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-9390 Function found_rows() gives incorrect result where the previous SELECT contains ORDER BY clause

Browse Source 
use the raw found_rows value only when SQL_CALC_FOUND_ROWS was specified
This commit is contained in:
Sergei Golubchik 2016-02-11 20:42:16 +01:00
parent 38b89a61c3
commit 9630eda0de
3 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
mysql-test/r/select_found.result
View File

@ -348,3 +348,18 @@ select found_rows();
found_rows() found_rows()
75 75
drop table t1; drop table t1;
create table t1(c1 int);
insert into t1 values(1),(2),(3),(4),(5);
select * from t1 order by c1 limit 2,1;
c1
3
select found_rows();
found_rows()
3
select sql_calc_found_rows * from t1 order by c1 limit 2,1;
c1
3
select found_rows();
found_rows()
5
drop table t1;

10
mysql-test/t/select_found.test
View File

@ -277,3 +277,13 @@ select sql_calc_found_rows * from t1 ignore index (i) where i = 0 order by v lim
select found_rows(); select found_rows();
drop table t1; drop table t1;
#
# MDEV-9390 Function found_rows() gives incorrect result where the previous SELECT contains ORDER BY clause
#
create table t1(c1 int);
insert into t1 values(1),(2),(3),(4),(5);
select * from t1 order by c1 limit 2,1;
select found_rows();
select sql_calc_found_rows * from t1 order by c1 limit 2,1;
select found_rows();
drop table t1;

2
sql/sql_select.cc
View File

@ -20813,7 +20813,7 @@ create_sort_index(THD *thd, JOIN *join, ORDER *order,
select, filesort_limit, 0, select, filesort_limit, 0,
&examined_rows, &found_rows); &examined_rows, &found_rows);
table->sort.found_records= filesort_retval; table->sort.found_records= filesort_retval;
tab->records= found_rows; // For SQL_CALC_ROWS tab->records= join->select_options & OPTION_FOUND_ROWS ? found_rows : filesort_retval;
if (quick_created) if (quick_created)
{ {