1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

5.0-bugteam->5.1-bugteam merge(bug#39040)

Browse Source
This commit is contained in:
Sergey Glukhov 2008-10-27 15:58:51 +04:00
commit 903c4dcf3b
3 changed files with 32 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/r/view.result
View File

@ -3672,6 +3672,8 @@ DROP VIEW v1;
# -- End of test case for Bug#35193. # -- End of test case for Bug#35193.
CREATE VIEW v1 AS SELECT 1;
DROP VIEW v1;
# ----------------------------------------------------------------- # -----------------------------------------------------------------
# -- End of 5.0 tests. # -- End of 5.0 tests.
# ----------------------------------------------------------------- # -----------------------------------------------------------------

9
mysql-test/t/view.test
View File

@ -3556,6 +3556,15 @@ DROP VIEW v1;
########################################################################### ###########################################################################
#
# Bug#39040: valgrind errors/crash when creating views with binlog logging
# enabled
#
# Bug is visible only when running in valgrind with binary logging.
CREATE VIEW v1 AS SELECT 1;
DROP VIEW v1;
--echo # ----------------------------------------------------------------- --echo # -----------------------------------------------------------------
--echo # -- End of 5.0 tests. --echo # -- End of 5.0 tests.
--echo # ----------------------------------------------------------------- --echo # -----------------------------------------------------------------

26
sql/sql_view.cc
View File

@ -816,13 +816,24 @@ static int mysql_register_view(THD *thd, TABLE_LIST *view,
DBUG_PRINT("info", ("View: %s", view_query.ptr())); DBUG_PRINT("info", ("View: %s", view_query.ptr()));
/* fill structure */ /* fill structure */
view->select_stmt.str= view_query.c_ptr_safe();
view->select_stmt.length= view_query.length();
view->source= thd->lex->create_view_select; view->source= thd->lex->create_view_select;
if (!thd->make_lex_string(&view->select_stmt, view_query.ptr(),
view_query.length(), false))
{
my_error(ER_OUT_OF_RESOURCES, MYF(0));
error= -1;
goto err;
}
view->file_version= 1; view->file_version= 1;
view->calc_md5(md5); view->calc_md5(md5);
view->md5.str= md5; if (!(view->md5.str= (char*) thd->memdup(md5, 32)))
{
my_error(ER_OUT_OF_RESOURCES, MYF(0));
error= -1;
goto err;
}
view->md5.length= 32; view->md5.length= 32;
can_be_merged= lex->can_be_merged(); can_be_merged= lex->can_be_merged();
if (lex->create_view_algorithm == VIEW_ALGORITHM_MERGE && if (lex->create_view_algorithm == VIEW_ALGORITHM_MERGE &&
@ -949,8 +960,13 @@ loop_out:
lex_string_set(&view->view_connection_cl_name, lex_string_set(&view->view_connection_cl_name,
view->view_creation_ctx->get_connection_cl()->name); view->view_creation_ctx->get_connection_cl()->name);
view->view_body_utf8.str= is_query.c_ptr_safe(); if (!thd->make_lex_string(&view->view_body_utf8, is_query.ptr(),
view->view_body_utf8.length= is_query.length(); is_query.length(), false))
{
my_error(ER_OUT_OF_RESOURCES, MYF(0));
error= -1;
goto err;
}
/* /*
Check that table of main select do not used in subqueries. Check that table of main select do not used in subqueries.