1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LPBUG#782223 : Memory released by Query_cache::resize() or Query_cache::free() contains active rwlocks.

Browse Source 
The bug was found by application verifier. 
Fixed by destroying locks prior to free(),
This commit is contained in:
Vladislav Vaintroub 2011-05-14 18:37:20 +02:00
parent 218c7665be
commit 8a376ae237
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sql/sql_cache.cc
View File

@ -2253,6 +2253,18 @@ void Query_cache::free_cache()
{ {
DBUG_ENTER("Query_cache::free_cache"); DBUG_ENTER("Query_cache::free_cache");
/* Destroy locks */
Query_cache_block *block= queries_blocks;
if (block)
{
do
{
Query_cache_query *query= block->query();
my_rwlock_destroy(&query->lock);
block= block->next;
} while (block != queries_blocks);
}
my_free((uchar*) cache, MYF(MY_ALLOW_ZERO_PTR)); my_free((uchar*) cache, MYF(MY_ALLOW_ZERO_PTR));
make_disabled(); make_disabled();
hash_free(&queries); hash_free(&queries);