1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-26914: Unreleased mutex in the exec_relay_log_event() function

Browse Source 
In the replication-related code, in the exec_relay_log_event() (slave.cc)
function, where the "data_lock" mutex is captured, this mutex is then not
released on one of the early return branches within a specific insert for
WSREP, namely under the branch: "if (wsrep_before_statement(thd))". As a
result, the mutex remains captured, resulting in errors or hangs.

This commit fixes this issue, which is now showing up as intermittent
failures in mtr tests for galera and galera_sr suites.
This commit is contained in:
Julius Goryavsky 2021-10-27 11:17:08 +02:00
parent 772d6d347d
commit 7948a1dc53
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sql/slave.cc
View File

@ -4124,6 +4124,8 @@ static int exec_relay_log_event(THD* thd, Relay_log_info* rli,
#ifdef WITH_WSREP #ifdef WITH_WSREP
if (wsrep_before_statement(thd)) if (wsrep_before_statement(thd))
{ {
mysql_mutex_unlock(&rli->data_lock);
delete ev;
WSREP_INFO("Wsrep before statement error"); WSREP_INFO("Wsrep before statement error");
DBUG_RETURN(1); DBUG_RETURN(1);
} }