From 792d6b348c52986f43b3f9b868b64ef02fbe836d Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Thu, 31 Jan 2013 13:19:53 +0100 Subject: [PATCH] skip cassandra.test unless cassandra is running --- mysql-test/include/have_cassandra.inc | 10 ---------- mysql-test/{ => suite/plugins}/r/cassandra.result | 0 mysql-test/suite/plugins/suite.pm | 8 ++++++++ .../plugins/t/cassandra.opt} | 0 mysql-test/{ => suite/plugins}/t/cassandra.test | 5 ++++- 5 files changed, 12 insertions(+), 11 deletions(-) delete mode 100644 mysql-test/include/have_cassandra.inc rename mysql-test/{ => suite/plugins}/r/cassandra.result (100%) rename mysql-test/{include/have_cassandra.opt => suite/plugins/t/cassandra.opt} (100%) rename mysql-test/{ => suite/plugins}/t/cassandra.test (99%) diff --git a/mysql-test/include/have_cassandra.inc b/mysql-test/include/have_cassandra.inc deleted file mode 100644 index d358e2ecc26..00000000000 --- a/mysql-test/include/have_cassandra.inc +++ /dev/null @@ -1,10 +0,0 @@ -# -# suite.pm will make sure that all tests including this file -# will be skipped unless innodb or xtradb is enabled -# -# The test below is redundant - -if (`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.ENGINES WHERE engine = 'cassandra' AND support IN ('YES', 'DEFAULT', 'ENABLED')`) -{ - --skip Test requires Cassandra. -} diff --git a/mysql-test/r/cassandra.result b/mysql-test/suite/plugins/r/cassandra.result similarity index 100% rename from mysql-test/r/cassandra.result rename to mysql-test/suite/plugins/r/cassandra.result diff --git a/mysql-test/suite/plugins/suite.pm b/mysql-test/suite/plugins/suite.pm index 9ada541e44b..610f94173f4 100644 --- a/mysql-test/suite/plugins/suite.pm +++ b/mysql-test/suite/plugins/suite.pm @@ -2,10 +2,18 @@ package My::Suite::Plugins; @ISA = qw(My::Suite); +sub cassandra_running() { + return 0 if IS_WINDOW; + system 'echo show version | cqlsh -3 2>/dev/null >/dev/null'; + return $? == 0; +} + sub skip_combinations { my %skip; $skip{'t/pam.test'} = 'No pam setup for mtr' unless -e '/etc/pam.d/mariadb_mtr'; + $skip{'t/cassandra.test'} = 'Cassandra is not running' + unless cassandra_running(); %skip; } diff --git a/mysql-test/include/have_cassandra.opt b/mysql-test/suite/plugins/t/cassandra.opt similarity index 100% rename from mysql-test/include/have_cassandra.opt rename to mysql-test/suite/plugins/t/cassandra.opt diff --git a/mysql-test/t/cassandra.test b/mysql-test/suite/plugins/t/cassandra.test similarity index 99% rename from mysql-test/t/cassandra.test rename to mysql-test/suite/plugins/t/cassandra.test index 2b92956d974..1543993843a 100644 --- a/mysql-test/t/cassandra.test +++ b/mysql-test/suite/plugins/t/cassandra.test @@ -1,7 +1,10 @@ # # Tests for cassandra storage engine # ---source include/have_cassandra.inc +if (`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.ENGINES WHERE engine = 'cassandra' AND support IN ('YES', 'DEFAULT', 'ENABLED')`) +{ + --skip Test requires Cassandra. +} --disable_warnings drop table if exists t0, t1;