1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-25222: mysqlbinlog --base64-output wrong option default drops BINLOG from output

Browse Source 
The --help comment for the --base64-output option in
mysqlbinlog was hard to decipher. This quick patch aims
to refine it.

Reviewed By:
==========
Andrei Elkin: <andrei.elkin@mariadb.com>
This commit is contained in:
Brandon Nesterenko 2021-05-18 09:52:13 -06:00
parent 2714158150
commit 78a0fe792a
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
client/mysqlbinlog.cc
View File

@ -1516,14 +1516,16 @@ static struct my_option my_options[] =
{"base64-output", OPT_BASE64_OUTPUT_MODE,
/* 'unspec' is not mentioned because it is just a placeholder. */
"Determine when the output statements should be base64-encoded BINLOG "
"statements: 'never' doesn't print binlog row events and should not be "
"used when directing output to a MariaDB master; "
"statements: "
"‘never’ neither prints base64 encodings nor verbose event data, and "
"will exit on error if a row-based event is found. "
"'decode-rows' decodes row events into commented SQL statements if the "
"--verbose option is also given; "
"'auto' prints base64 only when necessary (i.e., for row-based events and "
"format description events); "
"If no --base64-output=name option is given at all, the default is "
"'auto'.",
"--verbose option is also given. "
"‘auto’ outputs base64 encoded entries for row-based and format "
"description events. "
"If no option is given at all, the default is ‘auto', and is "
"consequently the only option that should be used when row-format events "
"are processed for re-execution.",
&opt_base64_output_mode_str, &opt_base64_output_mode_str,
0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
/*