1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

A fix for Bug#24486 "Valgrind warnings: sp_head(),

Browse Source 
deadlock_innodb:events_grant". This was a memory leak introduced by 
the patch for Bug 22830.
Post-review fixes.


sql/sql_parse.cc:
  A fix for Bug#24486 "Valgrind warnings: sp_head(),
   deadlock_innodb:events_grant": delete the sphead object before
  returning with an error.
This commit is contained in:
unknown 2006-11-28 21:35:20 +03:00
parent 49009cf8ea
commit 76833ac489
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sql/sql_parse.cc
View File

@ -3925,6 +3925,7 @@ end_with_restore_list:
} }
case SQLCOM_CREATE_EVENT: case SQLCOM_CREATE_EVENT:
case SQLCOM_ALTER_EVENT: case SQLCOM_ALTER_EVENT:
do
{ {
DBUG_ASSERT(lex->event_parse_data); DBUG_ASSERT(lex->event_parse_data);
if (lex->table_or_sp_used()) if (lex->table_or_sp_used())
@ -3950,16 +3951,15 @@ end_with_restore_list:
if (!res) if (!res)
send_ok(thd); send_ok(thd);
/* Don't do it, if we are inside a SP */ } while (0);
if (!thd->spcont) /* Don't do it, if we are inside a SP */
{ if (!thd->spcont)
delete lex->sphead; {
lex->sphead= NULL; delete lex->sphead;
} lex->sphead= NULL;
/* lex->unit.cleanup() is called outside, no need to call it here */
break;
} }
/* lex->unit.cleanup() is called outside, no need to call it here */
break;
case SQLCOM_DROP_EVENT: case SQLCOM_DROP_EVENT:
case SQLCOM_SHOW_CREATE_EVENT: case SQLCOM_SHOW_CREATE_EVENT:
{ {