1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes MDEV-7658: MDEV-7026 fix reintroduces MDEV-6615 on AArch64

Browse Source 
This is an addendum to the fix for MDEV-7026. The ARM memory model is
similar to that of PowerPC and thus needs the same semantics with
respect to memory barriers. That is, os_atomic_test_and_set_*_release()
must be a store with a release barrier followed by a full
barrier. Unlike x86 using __sync_lock_test_and_set() which is
implemented as “exclusive load with acquire barriers + exclusive store”
is insufficient in contexts where os_atomic_test_and_set_*_release()
macros are used.
This commit is contained in:
Alexey Kopytov 2015-05-26 23:56:00 +03:00
parent 17a37796e1
commit 70bc0a3ef4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
storage/innobase/include/os0sync.h
View File

@ -324,7 +324,7 @@ amount of increment. */
/**********************************************************//** /**********************************************************//**
Returns the old value of *ptr, atomically sets *ptr to new_val */ Returns the old value of *ptr, atomically sets *ptr to new_val */
#ifdef __powerpc__ #if defined(__powerpc__) || defined(__aarch64__)
/* /*
os_atomic_test_and_set_byte_release() should imply a release barrier before os_atomic_test_and_set_byte_release() should imply a release barrier before
setting, and a full barrier after. But __sync_lock_test_and_set() is only setting, and a full barrier after. But __sync_lock_test_and_set() is only

2
storage/xtradb/include/os0sync.h
View File

@ -331,7 +331,7 @@ amount of increment. */
/**********************************************************//** /**********************************************************//**
Returns the old value of *ptr, atomically sets *ptr to new_val */ Returns the old value of *ptr, atomically sets *ptr to new_val */
#ifdef __powerpc__ #if defined(__powerpc__) || defined(__aarch64__)
/* /*
os_atomic_test_and_set_byte_release() should imply a release barrier before os_atomic_test_and_set_byte_release() should imply a release barrier before
setting, and a full barrier after. But __sync_lock_test_and_set() is only setting, and a full barrier after. But __sync_lock_test_and_set() is only