1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug#19955: unsigned bigint used as signed with MOD function

Browse Source 
Problem:  When we have a really large number (between 2^63 and 2^64)
as the left side of the mod operator, it gets improperly corerced
into a signed value.

Solution:  Added check to see if the "negative" number is really
positive, and if so, cast it.
This commit is contained in:
cmiller@zippy.cornsilk.net 2006-11-15 12:23:07 -05:00
parent 2b3a69eb42
commit 5d4c57b900
3 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mysql-test/r/bigint.result
View File

@ -341,3 +341,14 @@ select * from t1 where bigint_col='17666000000000000000';
bigint_col
17666000000000000000
drop table t1;
bug 19955 -- mod is signed with bigint
select cast(10000002383263201056 as unsigned) mod 50 as result;
result
6
create table t1 (c1 bigint unsigned);
insert into t1 values (10000002383263201056);
select c1 mod 50 as result from t1;
result
6
drop table t1;

9
mysql-test/t/bigint.test
View File

@ -278,4 +278,13 @@ select * from t1 where bigint_col=17666000000000000000;
select * from t1 where bigint_col='17666000000000000000';
drop table t1;
--echo
--echo bug 19955 -- mod is signed with bigint
select cast(10000002383263201056 as unsigned) mod 50 as result;
create table t1 (c1 bigint unsigned);
insert into t1 values (10000002383263201056);
select c1 mod 50 as result from t1;
drop table t1;

4
sql/item_func.cc
View File

@ -1326,6 +1326,10 @@ longlong Item_func_mod::int_op()
signal_divide_by_null();
return 0;
}
if (args[0]->unsigned_flag)
return ((ulonglong) value) % val2;
return value % val2;
}