1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-23224 better defaults for Windows native threadpool implementation

Browse Source
This commit is contained in:
Vladislav Vaintroub 2020-07-20 08:08:00 +02:00
parent f026d4df61
commit 56990b18d9
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
sql/threadpool_win.cc
View File

@ -30,6 +30,7 @@
#include <debug_sync.h> #include <debug_sync.h>
#include <threadpool.h> #include <threadpool.h>
#include <windows.h> #include <windows.h>
#include <set_var.h>
#include "threadpool_winsockets.h" #include "threadpool_winsockets.h"
@ -345,12 +346,24 @@ int TP_pool_win::init()
InitializeThreadpoolEnvironment(&callback_environ); InitializeThreadpoolEnvironment(&callback_environ);
SetThreadpoolCallbackPool(&callback_environ, pool); SetThreadpoolCallbackPool(&callback_environ, pool);
if (threadpool_max_threads) if (IS_SYSVAR_AUTOSIZE(&threadpool_max_threads))
{
/*
Nr 500 comes from Microsoft documentation,
there is no API for GetThreadpoolThreadMaxThreads()
*/
SYSVAR_AUTOSIZE(threadpool_max_threads,500);
}
else
{ {
SetThreadpoolThreadMaximum(pool, threadpool_max_threads); SetThreadpoolThreadMaximum(pool, threadpool_max_threads);
} }
if (threadpool_min_threads) if (IS_SYSVAR_AUTOSIZE(&threadpool_min_threads))
{
SYSVAR_AUTOSIZE(threadpool_min_threads,1);
}
else
{ {
if (!SetThreadpoolThreadMinimum(pool, threadpool_min_threads)) if (!SetThreadpoolThreadMinimum(pool, threadpool_min_threads))
{ {
@ -359,6 +372,18 @@ int TP_pool_win::init()
} }
} }
if (IS_SYSVAR_AUTOSIZE(&global_system_variables.threadpool_priority))
{
/*
There is a notable overhead for "auto" priority implementation,
use "high" which handles socket IO callbacks as they come
without rescheduling to work queue.
*/
SYSVAR_AUTOSIZE(global_system_variables.threadpool_priority,
TP_PRIORITY_HIGH);
}
TP_POOL_STACK_INFORMATION stackinfo; TP_POOL_STACK_INFORMATION stackinfo;
stackinfo.StackCommit = 0; stackinfo.StackCommit = 0;
stackinfo.StackReserve = (SIZE_T)my_thread_stack_size; stackinfo.StackReserve = (SIZE_T)my_thread_stack_size;