From af64d85ab9cf99299c4990db46cdc2201baa4336 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 27 Mar 2006 17:45:06 -0800 Subject: [PATCH 1/2] Fix for bug #16855 BitKeeper/etc/ignore: Added mysql-test/r/bdb.log mysql-test/r/im_client_port.log to the ignore list client/mysql.cc: If --socket is not set, provides --protocol=TCP when --port= is specified (and --protocol= is not specified.) --- .bzrignore | 2 ++ client/mysql.cc | 11 +++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.bzrignore b/.bzrignore index e521692f6c2..f42630ae0ec 100644 --- a/.bzrignore +++ b/.bzrignore @@ -1275,3 +1275,5 @@ zlib/*.ds? zlib/*.vcproj scripts/mysql_upgrade include/openssl +mysql-test/r/bdb.log +mysql-test/r/im_client_port.log diff --git a/client/mysql.cc b/client/mysql.cc index eb6970691bb..2001056dea1 100644 --- a/client/mysql.cc +++ b/client/mysql.cc @@ -653,7 +653,7 @@ static struct my_option my_long_options[] = "Base name of shared memory.", (gptr*) &shared_memory_base_name, (gptr*) &shared_memory_base_name, 0, GET_STR_ALLOC, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, #endif - {"socket", 'S', "Socket file to use for connection.", + {"socket", 'S', "Socket file to use for connection. (This will override --port unless --protocol=TCP is specified.)", (gptr*) &opt_mysql_unix_port, (gptr*) &opt_mysql_unix_port, 0, GET_STR_ALLOC, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, #include "sslopt-longopts.h" @@ -939,7 +939,14 @@ static int get_options(int argc, char **argv) opt_reconnect= 0; connect_flag= 0; /* Not in interactive mode */ } - + + if (opt_mysql_port && (!opt_protocol) && (!opt_mysql_unix_port)) + { + /* Not checking return type since we are using a constant value */ + /* straight from the initialization of sql_protocol_typelib. */ + opt_protocol= find_type("TCP", &sql_protocol_typelib, 0); + } + if (strcmp(default_charset, charset_info->csname) && !(charset_info= get_charset_by_csname(default_charset, MY_CS_PRIMARY, MYF(MY_WME)))) From 63605b9fd467954dae2ef987412b625014395a7b Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 27 Mar 2006 18:25:35 -0800 Subject: [PATCH 2/2] Disable udf test BitKeeper/etc/ignore: Added mysql-test/r/udf.log to the ignore list mysql-test/t/disabled.def: Disable the udf test, per bug #18564. Permission by Brian --- .bzrignore | 1 + mysql-test/t/disabled.def | 1 + 2 files changed, 2 insertions(+) diff --git a/.bzrignore b/.bzrignore index f42630ae0ec..1bd9f91fccf 100644 --- a/.bzrignore +++ b/.bzrignore @@ -1277,3 +1277,4 @@ scripts/mysql_upgrade include/openssl mysql-test/r/bdb.log mysql-test/r/im_client_port.log +mysql-test/r/udf.log diff --git a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def index f71e24ff3ed..a836b1a2897 100644 --- a/mysql-test/t/disabled.def +++ b/mysql-test/t/disabled.def @@ -12,3 +12,4 @@ sp-goto : GOTO is currently is disabled - will be fixed in the future ndb_load : Bug#17233 +udf : Bug#18564 (Permission by Brian)