1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG#13337202 - REPLICATION PERFORMANCE DROP DUE TO "THE BINLOG MAY BE CORRUPTED" FLOOD

Browse Source 
In patch mysql-5.5:revno:3097.92.133, we made the gcc 4.6.1 compiler
to stop complaining about the fact that binlog_can_be_corrupted was
defined but not used. The fix consisted in checking the variable
and printing a warning message.

However, the fix caused a regression as a message was being printed
out when there was no corrupted binary log causing performance
problems and triggering users' suspicions when there was no need.

In BUG#13337202, we do not print any message and use the variable
in an "if" with an empty body to keep the compiler happy.
This commit is contained in:
Alfranio Correia 2011-11-02 15:28:18 +00:00
parent 28970ab87b
commit 4ee0f59565
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sql/sql_repl.cc
View File

@ -731,7 +731,15 @@ impossible position";
/Alfranio /Alfranio
*/ */
if (binlog_can_be_corrupted) if (binlog_can_be_corrupted)
sql_print_information("The binlog may be corrupted."); {
/*
Don't try to print out warning messages because this generates
erroneous messages in the error log and causes performance
problems.
/Alfranio
*/
}
pos = my_b_tell(&log); pos = my_b_tell(&log);
if (RUN_HOOK(binlog_transmit, before_send_event, if (RUN_HOOK(binlog_transmit, before_send_event,