1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-29298 INSERT ... SELECT Does not produce an optimizer trace

Browse Source 
Add INSERT ... SELECT to the list of commands that can be traced

Approved by Sergei Petrunia (sergey@mariadb.com)
This commit is contained in:
Oleg Smirnov 2023-07-06 11:55:40 +07:00
parent 5b0a4159ef
commit 48e4962c44
3 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mysql-test/main/opt_trace.result
View File

@ -9231,5 +9231,17 @@ json_detailed(json_extract(trace, '$**.in_to_subquery_conversion'))
] ]
set in_predicate_conversion_threshold=@tmp; set in_predicate_conversion_threshold=@tmp;
drop table t0; drop table t0;
#
# MDEV-29298: INSERT ... SELECT Does not produce an optimizer trace
#
create table t1 (a int, b int);
create table t2 (a int, b int);
insert into t1 values (1,1), (2,2), (3,3), (4,4), (5,5);
set optimizer_trace=1;
insert into t2 select * from t1 where a<= b and a>4;
select QUERY, LENGTH(trace)>1 from information_schema.optimizer_trace;
QUERY LENGTH(trace)>1
insert into t2 select * from t1 where a<= b and a>4 1
drop table t1, t2;
# End of 10.5 tests # End of 10.5 tests
set optimizer_trace='enabled=off'; set optimizer_trace='enabled=off';

14
mysql-test/main/opt_trace.test
View File

@ -861,5 +861,19 @@ set in_predicate_conversion_threshold=@tmp;
drop table t0; drop table t0;
--enable_view_protocol --enable_view_protocol
--echo #
--echo # MDEV-29298: INSERT ... SELECT Does not produce an optimizer trace
--echo #
create table t1 (a int, b int);
create table t2 (a int, b int);
insert into t1 values (1,1), (2,2), (3,3), (4,4), (5,5);
set optimizer_trace=1;
insert into t2 select * from t1 where a<= b and a>4;
select QUERY, LENGTH(trace)>1 from information_schema.optimizer_trace;
drop table t1, t2;
--echo # End of 10.5 tests --echo # End of 10.5 tests
set optimizer_trace='enabled=off'; set optimizer_trace='enabled=off';

3
sql/opt_trace.cc
View File

@ -103,7 +103,8 @@ inline bool sql_command_can_be_traced(enum enum_sql_command sql_command)
sql_command == SQLCOM_UPDATE || sql_command == SQLCOM_UPDATE ||
sql_command == SQLCOM_DELETE || sql_command == SQLCOM_DELETE ||
sql_command == SQLCOM_DELETE_MULTI || sql_command == SQLCOM_DELETE_MULTI ||
sql_command == SQLCOM_UPDATE_MULTI; sql_command == SQLCOM_UPDATE_MULTI ||
sql_command == SQLCOM_INSERT_SELECT;
} }
void opt_trace_print_expanded_query(THD *thd, SELECT_LEX *select_lex, void opt_trace_print_expanded_query(THD *thd, SELECT_LEX *select_lex,