1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-16615 ASAN SEGV in handler::print_error or server crash after error upon CREATE TABLE

Browse Source 
table->in_use is not always set and a KILL signal can arrive anytime.
This commit is contained in:
Sergei Golubchik 2018-06-28 16:17:21 +02:00
parent 8ca18294d5
commit 45cabf1017
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/r/max_statement_time.result
View File

@ -181,3 +181,6 @@ ERROR 70100: Query execution was interrupted (max_statement_time exceeded)
set max_statement_time = 0; set max_statement_time = 0;
drop procedure pr; drop procedure pr;
drop table t1; drop table t1;
SET max_statement_time= 1;
CREATE TABLE t ENGINE=InnoDB SELECT * FROM seq_1_to_50000;
ERROR 70100: Query execution was interrupted (max_statement_time exceeded)

8
mysql-test/t/max_statement_time.test
View File

@ -5,6 +5,7 @@
--source include/not_embedded.inc --source include/not_embedded.inc
--source include/have_innodb.inc --source include/have_innodb.inc
--source include/have_sequence.inc
--source include/not_valgrind.inc --source include/not_valgrind.inc
--echo --echo
@ -226,3 +227,10 @@ call pr();
set max_statement_time = 0; set max_statement_time = 0;
drop procedure pr; drop procedure pr;
drop table t1; drop table t1;
#
# MDEV-16615 ASAN SEGV in handler::print_error or server crash after error upon CREATE TABLE
#
SET max_statement_time= 1;
--error ER_STATEMENT_TIMEOUT
CREATE TABLE t ENGINE=InnoDB SELECT * FROM seq_1_to_50000;

4
sql/handler.cc
View File

@ -3413,8 +3413,8 @@ void handler::print_error(int error, myf errflag)
break; break;
case HA_ERR_ABORTED_BY_USER: case HA_ERR_ABORTED_BY_USER:
{ {
DBUG_ASSERT(table->in_use->killed); DBUG_ASSERT(ha_thd()->killed);
table->in_use->send_kill_message(); ha_thd()->send_kill_message();
DBUG_VOID_RETURN; DBUG_VOID_RETURN;
} }
case HA_ERR_WRONG_MRG_TABLE_DEF: case HA_ERR_WRONG_MRG_TABLE_DEF: