From 41cfdc838e551958b3b1e3a76f1e91040a628786 Mon Sep 17 00:00:00 2001 From: Kristian Nielsen Date: Mon, 23 Feb 2015 13:36:52 +0100 Subject: [PATCH] Add error handling on realpath() call. (Without this, it happened for me that realpath() failed returning undef for the default vardir. This in turn caused mysql-test-run.pl to delete the source mysql-test/ directory.) Backport from 10.1, it's not nice to get one's source directory nuked by a rouge mysql-test-run. --- mysql-test/mysql-test-run.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl index ae037c2485e..d989479b6ea 100755 --- a/mysql-test/mysql-test-run.pl +++ b/mysql-test/mysql-test-run.pl @@ -1502,7 +1502,12 @@ sub command_line_setup { { $default_vardir= "$glob_mysql_test_dir/var"; } - $default_vardir = realpath $default_vardir unless IS_WINDOWS; + unless (IS_WINDOWS) { + my $realpath = realpath($default_vardir); + die "realpath('$default_vardir') failed: $!\n" + unless defined($realpath) && $realpath ne ''; + $default_vardir = $realpath; + } if ( ! $opt_vardir ) {