1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-21534 - Improve innodb redo log group commit performance

Browse Source 
Instrument new synchronization primitive with thd_wait_begin/end
to inform threadpool about waits.

This considerably improve performance on write benchmarks
(e.g sysbench update_index) with generic threadpool, of course the cost is
possibility of many newly created threads.
This commit is contained in:
Vladislav Vaintroub 2020-03-15 21:40:11 +01:00
parent 637c17588a
commit 3c57693ff1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
storage/innobase/log/log0sync.cc
View File

@ -76,7 +76,7 @@ Note that if write operation is very fast, a) or b) can be fine as alternative.
#include <log0types.h> #include <log0types.h>
#include "log0sync.h" #include "log0sync.h"
#include <mysql/service_thd_wait.h>
/** /**
Helper class , used in group commit lock. Helper class , used in group commit lock.
@ -239,7 +239,10 @@ group_commit_lock::lock_return_code group_commit_lock::acquire(value_type num)
lk.unlock(); lk.unlock();
/* Sleep until woken in release().*/ /* Sleep until woken in release().*/
thd_wait_begin(0,THD_WAIT_GROUP_COMMIT);
thread_local_waiter.m_sema.wait(); thread_local_waiter.m_sema.wait();
thd_wait_end(0);
} }
return lock_return_code::EXPIRED; return lock_return_code::EXPIRED;
} }