1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG#46483 - drop table of partitioned table may leave

Browse Source 
extraneous file

Online/fast ALTER TABLE of a partitioned table may leave
temporary file in database directory.

Fixed by removing unnecessary call to
handler::ha_create_handler_files(), which was creating
partitioning definition file.

mysql-test/r/partition_innodb.result:
  A test case for BUG#46483.
mysql-test/t/partition_innodb.test:
  A test case for BUG#46483.
sql/unireg.cc:
  Do not call ha_create_handler_files() when we were requested
  to create only dot-frm file.
This commit is contained in:
Sergey Vojtovich 2009-09-02 16:19:28 +05:00
parent a00ba9ebea
commit 32c7efa6b4
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mysql-test/r/partition_innodb.result
View File

@ -256,3 +256,7 @@ SUBPARTITION BY KEY (char_column)
SUBPARTITIONS 2 SUBPARTITIONS 2
(PARTITION p1 VALUES LESS THAN (5) ENGINE = MyISAM) */ (PARTITION p1 VALUES LESS THAN (5) ENGINE = MyISAM) */
drop table t1; drop table t1;
CREATE TABLE t1 (a INT) ENGINE=InnoDB
PARTITION BY list(a) (PARTITION p1 VALUES IN (1));
CREATE INDEX i1 ON t1 (a);
DROP TABLE t1;

12
mysql-test/t/partition_innodb.test
View File

@ -270,3 +270,15 @@ PARTITION BY RANGE (int_column)
(PARTITION p1 VALUES LESS THAN (5)); (PARTITION p1 VALUES LESS THAN (5));
show create table t1; show create table t1;
drop table t1; drop table t1;
#
# BUG#46483 - drop table of partitioned table may leave extraneous file
# Note: was only repeatable with InnoDB plugin
#
CREATE TABLE t1 (a INT) ENGINE=InnoDB
PARTITION BY list(a) (PARTITION p1 VALUES IN (1));
CREATE INDEX i1 ON t1 (a);
DROP TABLE t1;
let $MYSQLD_DATADIR= `SELECT @@datadir`;
# Before the fix it should show extra file like #sql-2405_2.par
--list_files $MYSQLD_DATADIR/test/ *

8
sql/unireg.cc
View File

@ -412,10 +412,10 @@ int rea_create_table(THD *thd, const char *path,
DBUG_ASSERT(*fn_rext(frm_name)); DBUG_ASSERT(*fn_rext(frm_name));
if (thd->variables.keep_files_on_create) if (thd->variables.keep_files_on_create)
create_info->options|= HA_CREATE_KEEP_FILES; create_info->options|= HA_CREATE_KEEP_FILES;
if (file->ha_create_handler_files(path, NULL, CHF_CREATE_FLAG, create_info)) if (!create_info->frm_only &&
goto err_handler; (file->ha_create_handler_files(path, NULL, CHF_CREATE_FLAG,
if (!create_info->frm_only && ha_create_table(thd, path, db, table_name, create_info) ||
create_info,0)) ha_create_table(thd, path, db, table_name, create_info, 0)))
goto err_handler; goto err_handler;
DBUG_RETURN(0); DBUG_RETURN(0);