1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-15242 Poor RBR update performance with partitioned tables

Browse Source 
Observed and described
partitioned engine execution time difference
between master and slave was caused by excessive invocation
of base_engine::rnd_init which was done also for partitions
uninvolved into Rows-event operation.
The bug's slave slowdown therefore scales with the number of partitions.

Fixed with applying an upstream patch.

References:
----------
https://bugs.mysql.com/bug.php?id=73648
Bug#25687813 REPLICATION REGRESSION WITH RBR AND PARTITIONED TABLES
This commit is contained in:
Andrei Elkin 2018-06-19 18:14:47 +03:00
parent 364a20fe0b
commit 28e1f1453f
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sql/ha_partition.cc
View File

@ -5090,7 +5090,8 @@ int ha_partition::rnd_pos_by_record(uchar *record)
if (unlikely(get_part_for_delete(record, m_rec0, m_part_info, &m_last_part))) if (unlikely(get_part_for_delete(record, m_rec0, m_part_info, &m_last_part)))
DBUG_RETURN(1); DBUG_RETURN(1);
DBUG_RETURN(handler::rnd_pos_by_record(record)); int err= m_file[m_last_part]->rnd_pos_by_record(record);
DBUG_RETURN(err);
} }

10
sql/handler.h
View File

@ -3042,9 +3042,17 @@ private:
*/ */
virtual int rnd_pos_by_record(uchar *record) virtual int rnd_pos_by_record(uchar *record)
{ {
int error;
DBUG_ASSERT(table_flags() & HA_PRIMARY_KEY_REQUIRED_FOR_POSITION); DBUG_ASSERT(table_flags() & HA_PRIMARY_KEY_REQUIRED_FOR_POSITION);
error = ha_rnd_init(false);
if (error != 0)
return error;
position(record); position(record);
return rnd_pos(record, ref); error = ha_rnd_pos(record, ref);
ha_rnd_end();
return error;
} }
virtual int read_first_row(uchar *buf, uint primary_key); virtual int read_first_row(uchar *buf, uint primary_key);
public: public:

4
sql/log_event.cc
View File

@ -12135,10 +12135,6 @@ int Rows_log_event::find_row(rpl_group_info *rgi)
int error; int error;
DBUG_PRINT("info",("locating record using primary key (position)")); DBUG_PRINT("info",("locating record using primary key (position)"));
if (!table->file->inited &&
(error= table->file->ha_rnd_init_with_error(0)))
DBUG_RETURN(error);
error= table->file->ha_rnd_pos_by_record(table->record[0]); error= table->file->ha_rnd_pos_by_record(table->record[0]);
if (error) if (error)
{ {