From 258b84d6c00cea7dd236926b4279f1481ce36923 Mon Sep 17 00:00:00 2001 From: "dlenev@brandersnatch.localdomain" <> Date: Fri, 24 Sep 2004 17:55:43 +0400 Subject: [PATCH] For now we will require super privilege for creating/dropping trigger because proper privilege checking is not in place yet. --- sql/sql_trigger.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sql/sql_trigger.cc b/sql/sql_trigger.cc index c376e86f18c..add4078ce8e 100644 --- a/sql/sql_trigger.cc +++ b/sql/sql_trigger.cc @@ -2,6 +2,7 @@ #include "sp_head.h" #include "sql_trigger.h" #include "parse_file.h" +#include "sql_acl.h" static const LEX_STRING triggers_file_type= {(char *)"TRIGGERS", 8}; @@ -54,7 +55,13 @@ int mysql_create_or_drop_trigger(THD *thd, TABLE_LIST *tables, bool create) if (open_and_lock_tables(thd, tables)) DBUG_RETURN(-1); - // TODO: We should check if user has TRIGGER privilege for table here. + /* + TODO: We should check if user has TRIGGER privilege for table here. + Now we just require SUPER privilege for creating/dropping because + we don't have proper privilege checking for triggers in place yet. + */ + if (check_global_access(thd, SUPER_ACL)) + DBUG_RETURN(1); table= tables->table;