From 24a6b413489e82971673d2a68e754fc30add3f9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Lindstr=C3=B6m?= Date: Wed, 3 Dec 2014 13:45:21 +0200 Subject: [PATCH] Move page initialization to better place. --- storage/innobase/fil/fil0pagecompress.cc | 10 ---------- storage/xtradb/fil/fil0pagecompress.cc | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/storage/innobase/fil/fil0pagecompress.cc b/storage/innobase/fil/fil0pagecompress.cc index 635e9c88fad..c74740ac9e1 100644 --- a/storage/innobase/fil/fil0pagecompress.cc +++ b/storage/innobase/fil/fil0pagecompress.cc @@ -461,9 +461,6 @@ fil_compress_page( ut_a(block_size > 0); #endif write_size = (size_t)ut_uint64_align_up((ib_uint64_t)write_size, block_size); - /* Initialize rest of the written data to avoid - uninitialized bytes */ - memset(out_buf+tmp, 0, write_size-tmp); #ifdef UNIV_DEBUG ut_a(write_size > 0 && ((write_size % block_size) == 0)); ut_a(write_size >= tmp); @@ -480,13 +477,6 @@ fil_compress_page( srv_stats.page_compression_saved.add((len - write_size)); srv_stats.pages_page_compressed.inc(); - if (!srv_use_trim) { - /* If persistent trims are not used we always write full - page and end of the page needs to be initialized.*/ - memset(out_buf+write_size, 0, len-write_size); - write_size = len; - } - *out_len = write_size; return(out_buf); diff --git a/storage/xtradb/fil/fil0pagecompress.cc b/storage/xtradb/fil/fil0pagecompress.cc index 0b622bac8ba..b1d5412b9f1 100644 --- a/storage/xtradb/fil/fil0pagecompress.cc +++ b/storage/xtradb/fil/fil0pagecompress.cc @@ -458,9 +458,6 @@ fil_compress_page( ut_a(block_size > 0); #endif write_size = (size_t)ut_uint64_align_up((ib_uint64_t)write_size, block_size); - /* Initialize rest of the written data to avoid - uninitialized bytes */ - memset(out_buf+tmp, 0, write_size-tmp); #ifdef UNIV_DEBUG ut_a(write_size > 0 && ((write_size % block_size) == 0)); ut_a(write_size >= tmp); @@ -477,13 +474,6 @@ fil_compress_page( srv_stats.page_compression_saved.add((len - write_size)); srv_stats.pages_page_compressed.inc(); - if (!srv_use_trim) { - /* If persistent trims are not used we always write full - page and end of the page needs to be initialized.*/ - memset(out_buf+write_size, 0, len-write_size); - write_size = len; - } - *out_len = write_size; return(out_buf);