1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-16868 Same query gives different results

Browse Source 
An INSERT into a temporary table would fail to set the
index page as modified. If there were no other write operations
(such as UPDATE or DELETE) to the page, and the page was evicted,
we would read back the old contents of the page, causing
corruption or loss of data.

page_cur_insert_rec_write_log(): Call mtr_t::set_modified()
for temporary tables. Normally this is part of the mlog_open()
call, but the mlog_open() call was only present in debug builds.
This regression was caused by
commit 48192f963a3a85a5127da5cc5cf485f07d72bc9d
which was preparation for MDEV-11369 and supposed to affect
debug builds only.

Thanks to Thirunarayanan Balathandayuthapani for debugging.
This commit is contained in:
Marko Mäkelä 2018-08-24 09:38:52 +03:00
parent c164d0cc62
commit 1b4c5b7327
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
storage/innobase/page/page0cur.cc
View File

@ -857,7 +857,8 @@ page_cur_insert_rec_write_log(
ulint i;
if (dict_table_is_temporary(index->table)) {
ut_ad(!mlog_open(mtr, 0));
mtr->set_modified();
ut_ad(mtr->get_log_mode() == MTR_LOG_NO_REDO);
return;
}