1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-4436 CHANGE COLUMN IF EXISTS does not work and throws wrong warning.

Browse Source 
Use sql_field->change parameter as the name of the field.
This commit is contained in:
Alexey Botchkov 2013-11-11 19:45:55 +04:00
parent 3cf7e283a6
commit 06a91b18d7
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mysql-test/r/alter_table.result
View File

@ -1899,3 +1899,11 @@ alter table t1 add key if not exists (i);
Warnings: Warnings:
Note 1061 Duplicate key name 'i' Note 1061 Duplicate key name 'i'
DROP TABLE t1; DROP TABLE t1;
create table t1 (a int);
alter table t1 change column if exists a b bigint;
show create table t1;
Table Create Table
t1 CREATE TABLE `t1` (
`b` bigint(20) DEFAULT NULL
) ENGINE=MyISAM DEFAULT CHARSET=latin1
DROP TABLE t1;

8
mysql-test/t/alter_table.test
View File

@ -1643,3 +1643,11 @@ alter table t1 add key (i);
alter table t1 add key if not exists (i); alter table t1 add key if not exists (i);
DROP TABLE t1; DROP TABLE t1;
#
# MDEV-4436 CHANGE COLUMN IF EXISTS does not work and throws wrong warning.
#
create table t1 (a int);
alter table t1 change column if exists a b bigint;
show create table t1;
DROP TABLE t1;

2
sql/sql_table.cc
View File

@ -5309,7 +5309,7 @@ handle_if_exists_options(THD *thd, TABLE *table, Alter_info *alter_info)
for (f_ptr=table->field; *f_ptr; f_ptr++) for (f_ptr=table->field; *f_ptr; f_ptr++)
{ {
if (my_strcasecmp(system_charset_info, if (my_strcasecmp(system_charset_info,
sql_field->field_name, (*f_ptr)->field_name) == 0) sql_field->change, (*f_ptr)->field_name) == 0)
{ {
break; break;
} }